Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository link #1103

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Fix repository link #1103

merged 2 commits into from
Jan 4, 2024

Conversation

kachkaev
Copy link
Contributor

@kachkaev kachkaev commented Dec 7, 2023

I was exploring hotkey libraries and came across react-hotkeys-hook. Great work! ๐Ÿ‘ When comparing the alternatives using NPM trends, I noticed that your libโ€™s GitHub link ๐Ÿ–๏ธ was missing:

Screenshot 2023-12-07 at 15 02 04

I believe that itโ€™s because of a username in the URL, which this PR removes.

Keeping .git in the end is fine, AFAIU (example). I guess we could keep a short notation (just a string) but I switched to an object to match docs.

Interestingly, npmjs.com recognises the URL correctly and removes the username. But because it is unconventional, some tools like NPM trends may struggle with this metadata format.

Screenshot 2023-12-07 at 15 17 46

A new version of the package needs to be published for the metadata to get fixed.

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
react-hotkeys-hook โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Dec 7, 2023 3:27pm

@kachkaev kachkaev marked this pull request as ready for review December 7, 2023 15:35
@JohannesKlauss JohannesKlauss merged commit 1da53b4 into JohannesKlauss:main Jan 4, 2024
2 checks passed
renovate bot added a commit to simonknittel/sinister-incorporated that referenced this pull request Jan 11, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[react-hotkeys-hook](https://johannesklauss.github.io/react-hotkeys-hook/)
([source](https://togithub.com/JohannesKlauss/react-keymap-hook)) |
[`4.4.1` ->
`4.4.3`](https://renovatebot.com/diffs/npm/react-hotkeys-hook/4.4.1/4.4.3)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/react-hotkeys-hook/4.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-hotkeys-hook/4.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-hotkeys-hook/4.4.1/4.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-hotkeys-hook/4.4.1/4.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>JohannesKlauss/react-keymap-hook (react-hotkeys-hook)</summary>

###
[`v4.4.3`](https://togithub.com/JohannesKlauss/react-hotkeys-hook/releases/tag/v4.4.3)

[Compare
Source](https://togithub.com/JohannesKlauss/react-keymap-hook/compare/v4.4.2...v4.4.3)

##### What's Changed

- Call ignoreEventWhen callback only on hotkey matches by
[@&#8203;LuanScudeler](https://togithub.com/LuanScudeler) in
[JohannesKlauss/react-hotkeys-hook#1096
- Fix CI (update triggers, format files) by
[@&#8203;kachkaev](https://togithub.com/kachkaev) in
[JohannesKlauss/react-hotkeys-hook#1105
- fix: focus trap did not work for shadow root by
[@&#8203;artchen-db](https://togithub.com/artchen-db) in
[JohannesKlauss/react-hotkeys-hook#1108
- chore(deps): update dependency typescript to v5.3.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1106
- chore(deps): update dependency
[@&#8203;testing-library/user-event](https://togithub.com/testing-library/user-event)
to v14.5.2 by [@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1097
- chore(deps): update dependency tslib to v2.6.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1102
- chore(deps): update dependency
[@&#8203;testing-library/react](https://togithub.com/testing-library/react)
to v14.1.2 by [@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1094
- chore(deps): update react monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1093
- chore(deps): update dependency
[@&#8203;types/jest](https://togithub.com/types/jest) to v29.5.11 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1092
- chore(deps): update babel monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1091

##### New Contributors

- [@&#8203;artchen-db](https://togithub.com/artchen-db) made their first
contribution in
[JohannesKlauss/react-hotkeys-hook#1108

**Full Changelog**:
JohannesKlauss/react-hotkeys-hook@v4.4.2...v4.4.3

###
[`v4.4.2`](https://togithub.com/JohannesKlauss/react-hotkeys-hook/releases/tag/v4.4.2)

[Compare
Source](https://togithub.com/JohannesKlauss/react-keymap-hook/compare/v4.4.1...v4.4.2)

#### What's Changed

- Improve words in hook API docs by
[@&#8203;jrysana](https://togithub.com/jrysana) in
[JohannesKlauss/react-hotkeys-hook#1050
- chore(deps): update jest monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1053
- chore(deps): update react monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1054
- Tiny fix: correct name of enableScope/disableScope in README and test
description. by [@&#8203;rewbs](https://togithub.com/rewbs) in
[JohannesKlauss/react-hotkeys-hook#1056
- chore(deps): update dependency
[@&#8203;types/react](https://togithub.com/types/react) to v18.2.17 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1059
- chore(deps): update jest monorepo to v29.6.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1060
- Bump word-wrap from 1.2.3 to 1.2.4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[JohannesKlauss/react-hotkeys-hook#1055
- chore(deps): update dependency
[@&#8203;types/react](https://togithub.com/types/react) to v18.2.18 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1061
- fix(deps): update dependency react-hotkeys-hook to v4.4.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1062
- chore(deps): update dependency
[@&#8203;types/react](https://togithub.com/types/react) to v18.2.20 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1065
- fix(deps): update docusaurus monorepo to v2.4.1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1066
- chore(deps): update dependency
[@&#8203;types/react](https://togithub.com/types/react) to v18.2.21 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1071
- chore(deps): update jest monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1072
- chore(deps): update babel monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1075
- chore(deps): update dependency
[@&#8203;testing-library/jest-dom](https://togithub.com/testing-library/jest-dom)
to v5.17.0 by [@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1076
- chore(deps): update jest monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1078
- chore(deps): update react monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1079
- chore(deps): update react monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1082
- fix(deps): update docusaurus monorepo to v2.4.3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1083
- chore(deps): update react monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1084
- chore(deps): update babel monorepo to v7.23.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1085
- chore(deps): update dependency
[@&#8203;types/jest](https://togithub.com/types/jest) to v29.5.6 by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1088
- chore(deps): update react monorepo by
[@&#8203;renovate](https://togithub.com/renovate) in
[JohannesKlauss/react-hotkeys-hook#1089
- Fix: duplicate hotkey activiation by
[@&#8203;brendanlaschke](https://togithub.com/brendanlaschke) in
[JohannesKlauss/react-hotkeys-hook#1080
- Bump postcss from 8.4.14 to 8.4.31 in /documentation by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[JohannesKlauss/react-hotkeys-hook#1081
- Bump [@&#8203;babel/traverse](https://togithub.com/babel/traverse)
from 7.18.0 to 7.23.2 in /documentation by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[JohannesKlauss/react-hotkeys-hook#1086
- Fix repository link by
[@&#8203;kachkaev](https://togithub.com/kachkaev) in
[JohannesKlauss/react-hotkeys-hook#1103

#### New Contributors

- [@&#8203;jrysana](https://togithub.com/jrysana) made their first
contribution in
[JohannesKlauss/react-hotkeys-hook#1050
- [@&#8203;rewbs](https://togithub.com/rewbs) made their first
contribution in
[JohannesKlauss/react-hotkeys-hook#1056
- [@&#8203;brendanlaschke](https://togithub.com/brendanlaschke) made
their first contribution in
[JohannesKlauss/react-hotkeys-hook#1080
- [@&#8203;kachkaev](https://togithub.com/kachkaev) made their first
contribution in
[JohannesKlauss/react-hotkeys-hook#1103

**Full Changelog**:
JohannesKlauss/react-hotkeys-hook@v4.4.1...v4.4.2

</details>

---

### Configuration

๐Ÿ“… **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

๐Ÿšฆ **Automerge**: Enabled.

โ™ป **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

๐Ÿ”• **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/simonknittel/sinister-incorporated).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants