Change command wrapping to get w1070 working #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The left and right surround parameter included \r\n which doesn't work correctly with Benq w1070. This changes that to only include \r which works fine.
I'm not sure if there are other Benq devices out there that actually expects \r\n, so that we should write another model file, or if this can be applied as is.
When we run this we can see that the first character received in the response is '>'. This is ASCII 0x3e and is actually a response code.
According to the manual the correct workflow would be something like
But this works good enough for most, including myself :)