Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change command wrapping to get w1070 working #7

Merged
merged 1 commit into from
Oct 19, 2015

Conversation

plajjan
Copy link
Contributor

@plajjan plajjan commented Oct 19, 2015

The left and right surround parameter included \r\n which doesn't work correctly with Benq w1070. This changes that to only include \r which works fine.

I'm not sure if there are other Benq devices out there that actually expects \r\n, so that we should write another model file, or if this can be applied as is.

When we run this we can see that the first character received in the response is '>'. This is ASCII 0x3e and is actually a response code.

kll@PompousTheather:~/pyjector$ ./pyjector_controller -v benq /dev/ttyUSB0 power status
1445271538.029446 INFO send: '\r*pow=?#\r'
1445271539.032583 INFO recv: '>*pow=?#\r\r\n*POW=OFF#\r\n'

According to the manual the correct workflow would be something like

  • send \r
  • wait for response, either 0x3e (positive) or 0xd,0xa (negative)
  • if positive response, send the actual command
  • get response

But this works good enough for most, including myself :)

The left and right surround parameter included \r\n which doesn't work
correctly with Benq w1070. This changes that to only include \r which works
fine.
@JohnBrodie
Copy link
Owner

Thanks for debugging this. You're not the first to mention the issue, so I'll merge this and we'll worry about splitting the configs only if it's needed.

JohnBrodie added a commit that referenced this pull request Oct 19, 2015
Change command wrapping to get w1070 working
@JohnBrodie JohnBrodie merged commit aea7c55 into JohnBrodie:master Oct 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants