fix(hmr): more precise matching #141
Open
+23
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've applied your patch with pnpm patch. When I edit the layout or one of its inner components it seems to trigger something, but the data in the browser is not updated. Is there anything special that I need to do to get this working? |
|
Any update here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest vite demo test, if I manually update an already existing layout, restart is required for it to take effect, this pr fixes the issue。
There are no break changes and it works fine 🥰
A repo that reproduces the problem → vue-layout-demo
Start the service and modify
src/_base/layouts/Layout.vueto find the problem.