Fix inconsistencies for DJ and KM #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
espindola
force-pushed
the
check-length
branch
2 times, most recently
from
83ea875
to
e24a027
Compare
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
==========================================
- Coverage 95.37% 95.11% -0.27%
==========================================
Files 2 2
Lines 303 307 +4
Branches 303 307 +4
==========================================
+ Hits 289 292 +3
- Misses 5 6 +1
Partials 9 9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @espindola. I've merged and update the bban_format as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inconsistencies for DJ and KM
The expected size didn't match the size of the verification string.
For DJ, https://www.swift.com/node/11971 list a different format and I
am using that.
I could not find the canonical source for KM, and I am assuming it is
the format that is wrong.