Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save augmentations #593

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Save augmentations #593

merged 8 commits into from
Jul 7, 2023

Conversation

RakshitKhajuria
Copy link
Contributor

This PR aims at only saving the augmented rows.

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@RakshitKhajuria RakshitKhajuria added ⭐ Feature Indicates new feature requests v2.1.0 Issue or request to be done in v2.1.0 release labels Jul 5, 2023
@RakshitKhajuria RakshitKhajuria linked an issue Jul 5, 2023 that may be closed by this pull request
Save augmentations #504
Closed
JulesBelveze
JulesBelveze suggested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just minor changes

langtest/augmentation/__init__.py Outdated Show resolved Hide resolved
JulesBelveze
JulesBelveze approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RakshitKhajuria
Copy link
Contributor Author

LGTM 🚀

Thanks for the review !

@JulesBelveze JulesBelveze merged commit d865ff4 into release/1.1.0 Jul 7, 2023
@JulesBelveze JulesBelveze deleted the Save-augmentations branch July 7, 2023 14:13
@ArshaanNazir ArshaanNazir removed the v2.1.0 Issue or request to be done in v2.1.0 release label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesBelveze JulesBelveze JulesBelveze approved these changes

@chakravarthik27 chakravarthik27 Awaiting requested review from chakravarthik27

Assignees

@RakshitKhajuria RakshitKhajuria

@Prikshit7766 Prikshit7766

Labels
⭐ Feature Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save augmentations
4 participants
@RakshitKhajuria @JulesBelveze @ArshaanNazir @Prikshit7766