Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blogpost notebook #634

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Blogpost notebook #634

merged 6 commits into from
Jul 17, 2023

Conversation

Prikshit7766
Copy link
Contributor

@Prikshit7766 Prikshit7766 commented Jul 17, 2023 •
edited
Loading

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

added the Healthcare NER Evaluation notebook for a blog post and made updates to the website and updated HF dataset notebook for summarization

@Prikshit7766 Prikshit7766 self-assigned this Jul 17, 2023
@Prikshit7766 Prikshit7766 linked an issue Jul 17, 2023 that may be closed by this pull request
Write blogpost #608
Closed
@Prikshit7766 Prikshit7766 added the v2.1.0 Issue or request to be done in v2.1.0 release label Jul 17, 2023
JulesBelveze
JulesBelveze reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prikshit7766 aren't we getting rid of the tests with a score of 1?

@Prikshit7766
Copy link
Contributor Author

Prikshit7766 commented Jul 17, 2023 •
edited
Loading

@Prikshit7766 aren't we getting rid of the tests with a score of 1?
yes but i think we keep add_punctuation and strip__punctuation

@ArshaanNazir ArshaanNazir merged commit 935e07b into release/1.1.0 Jul 17, 2023
@ArshaanNazir ArshaanNazir deleted the blogpost-notebook branch July 18, 2023 17:42
@ArshaanNazir ArshaanNazir removed the v2.1.0 Issue or request to be done in v2.1.0 release label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesBelveze JulesBelveze JulesBelveze approved these changes

@ArshaanNazir ArshaanNazir Awaiting requested review from ArshaanNazir

Assignees

@Prikshit7766 Prikshit7766

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write blogpost
3 participants
@Prikshit7766 @JulesBelveze @ArshaanNazir