Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NER export #657

Merged
merged 13 commits into from
Jul 21, 2023
Merged

fix: NER export #657

merged 13 commits into from
Jul 21, 2023

Conversation

JulesBelveze
Copy link
Contributor

This PR aims at fixing the behaviour of the .export method of the CSVDataset and the ConllDataset for the NER task.

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@JulesBelveze
Copy link
Contributor Author

@chakravarthik27 @ArshaanNazir the previous behaviour of the export method was quite weird:

  • for Conll: only writing the entities with a label != 0 to file
  • for CSV: one row was equal to one token

Hope I didn't screw up other components, but it didn't seem to be coupled to other objects.

@ArshaanNazir
Copy link
Collaborator

ConllDataset

Looks fine. I don't think it will affect other things in our flow.

@JulesBelveze JulesBelveze merged commit cc2c9de into main Jul 21, 2023
3 checks passed
@JulesBelveze JulesBelveze deleted the fix/ner-csv-export branch July 21, 2023 08:45
@JulesBelveze JulesBelveze restored the fix/ner-csv-export branch July 21, 2023 08:56
@JulesBelveze JulesBelveze deleted the fix/ner-csv-export branch July 21, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants