This repository has been archived by the owner on Jan 4, 2020. It is now read-only.
Adds linkable library for all dependencies generated in a Marathon scripts #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After removing a cached version of the generated |
JohnSundell
reviewed
Dec 9, 2017
| @@ -364,6 +364,7 @@ public final class PackageManager { | |||
| "import PackageDescription\n\n" + | |||
| "let package = Package(\n" + | |||
| " name: \"\(masterPackageName)\",\n" + | |||
| " products: [.library(name: \"Dependencies\", type: .dynamic, targets: [\"\(masterPackageName)\"])],\n" + | |||
There was a problem hiding this comment.
What do you think about calling this MarathonDependencies to be a bit more clear where it comes from?
|
Yep - this is cool with me too. Let's do it. |
|
🎉 I'll send a PR to Danger-Swift to use this. |
|
Awesome 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a a linkable library for the dependencies generated in Marathon scripts. tl;dr Danger uses Marathon to download its dependencies, but those deps need to be exposed to be linked against by Danger.
Paired on this with @orta. We used the name
Dependenciesfor everything since it's pretty generic and captured all of the root-level dependencies. This will allow us to change this line:https://github.com/danger/danger-swift/blob/5fd83392054054740cb4922a44fd4d59d2d6b05c/Sources/Runner/Commands/Runner.swift#L61
... to include
libArgs += ["-lDependencies"]and expose Danger-Swift plugin symbols toDangerfile.swiftfiles. Let me know if I can clarify anything – thanks!