Adopt Plot's new Component-based API #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump Plot to version `0.9.0`. - Publish now ships with a few implementations of Plot's new `Component` protocol - specifically `Markdown` (for rendering Markdown inline within a component hierarchy), `VideoPlayer` (for rendering an inline video player), and an extension that makes it possible to directly use Plot's `AudioPlayer` component with Publish's `Audio` model. - The `Content.Body` type now also conforms to `Component`, which makes it possible to place such instances directly within a component hierarchy. That type has now also been fully documented, since it was previously missing documentation for some of its properties and initializers. - The built-in Foundation theme as been rewritten using the new component API. While it remains functionally identical to the previous implementation, it should act as a nice example of how this new API can be used. - Because Publish now ships with a type called `Markdown`, it's possible that some API users might need to disambiguate between this new type and Ink's `Markdown` type. However, that tradeoff was considered worth it, since using the new `Markdown` component will likely be a much more common use case.
mwermeester
pushed a commit
to mwermeester/Publish
that referenced
this pull request
May 11, 2021
- Bump Plot to version `0.9.0`. - Publish now ships with a few implementations of Plot's new `Component` protocol - specifically `Markdown` (for rendering Markdown inline within a component hierarchy), `VideoPlayer` (for rendering an inline video player), and an extension that makes it possible to directly use Plot's `AudioPlayer` component with Publish's `Audio` model. - The `Content.Body` type now also conforms to `Component`, which makes it possible to place such instances directly within a component hierarchy. That type has now also been fully documented, since it was previously missing documentation for some of its properties and initializers. - The built-in Foundation theme as been rewritten using the new component API. While it remains functionally identical to the previous implementation, it should act as a nice example of how this new API can be used. - Because Publish now ships with a type called `Markdown`, it's possible that some API users might need to disambiguate between this new type and Ink's `Markdown` type. However, that tradeoff was considered worth it, since using the new `Markdown` component will likely be a much more common use case.
mwermeester
pushed a commit
to mwermeester/Publish
that referenced
this pull request
Jul 4, 2021
- Bump Plot to version `0.9.0`. - Publish now ships with a few implementations of Plot's new `Component` protocol - specifically `Markdown` (for rendering Markdown inline within a component hierarchy), `VideoPlayer` (for rendering an inline video player), and an extension that makes it possible to directly use Plot's `AudioPlayer` component with Publish's `Audio` model. - The `Content.Body` type now also conforms to `Component`, which makes it possible to place such instances directly within a component hierarchy. That type has now also been fully documented, since it was previously missing documentation for some of its properties and initializers. - The built-in Foundation theme as been rewritten using the new component API. While it remains functionally identical to the previous implementation, it should act as a nice example of how this new API can be used. - Because Publish now ships with a type called `Markdown`, it's possible that some API users might need to disambiguate between this new type and Ink's `Markdown` type. However, that tradeoff was considered worth it, since using the new `Markdown` component will likely be a much more common use case.
mwermeester
added a commit
to mwermeester/Publish
that referenced
this pull request
Jul 4, 2021
This reverts commit 1402af3.
mwermeester
pushed a commit
to mwermeester/Publish
that referenced
this pull request
Jul 4, 2021
- Bump Plot to version `0.9.0`. - Publish now ships with a few implementations of Plot's new `Component` protocol - specifically `Markdown` (for rendering Markdown inline within a component hierarchy), `VideoPlayer` (for rendering an inline video player), and an extension that makes it possible to directly use Plot's `AudioPlayer` component with Publish's `Audio` model. - The `Content.Body` type now also conforms to `Component`, which makes it possible to place such instances directly within a component hierarchy. That type has now also been fully documented, since it was previously missing documentation for some of its properties and initializers. - The built-in Foundation theme as been rewritten using the new component API. While it remains functionally identical to the previous implementation, it should act as a nice example of how this new API can be used. - Because Publish now ships with a type called `Markdown`, it's possible that some API users might need to disambiguate between this new type and Ink's `Markdown` type. However, that tradeoff was considered worth it, since using the new `Markdown` component will likely be a much more common use case.
mwermeester
added a commit
to mwermeester/Publish
that referenced
this pull request
Jul 4, 2021
This reverts commit 1402af3.
mwermeester
pushed a commit
to mwermeester/Publish
that referenced
this pull request
Apr 24, 2022
- Bump Plot to version `0.9.0`. - Publish now ships with a few implementations of Plot's new `Component` protocol - specifically `Markdown` (for rendering Markdown inline within a component hierarchy), `VideoPlayer` (for rendering an inline video player), and an extension that makes it possible to directly use Plot's `AudioPlayer` component with Publish's `Audio` model. - The `Content.Body` type now also conforms to `Component`, which makes it possible to place such instances directly within a component hierarchy. That type has now also been fully documented, since it was previously missing documentation for some of its properties and initializers. - The built-in Foundation theme as been rewritten using the new component API. While it remains functionally identical to the previous implementation, it should act as a nice example of how this new API can be used. - Because Publish now ships with a type called `Markdown`, it's possible that some API users might need to disambiguate between this new type and Ink's `Markdown` type. However, that tradeoff was considered worth it, since using the new `Markdown` component will likely be a much more common use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.9.0.Componentprotocol - specificallyMarkdown(for rendering Markdown inline within a component hierarchy),VideoPlayer(for rendering an inline video player), and an extension that makes it possible to directly use Plot'sAudioPlayercomponent with Publish'sAudiomodel.Content.Bodytype now also conforms toComponent, which makes it possible to place such instances directly within a component hierarchy. That type has now also been fully documented, since it was previously missing documentation for some of its properties and initializers.Markdown, it's possible that some API users might need to disambiguate between this new type and Ink'sMarkdowntype. However, that tradeoff was considered worth it, since using the newMarkdowncomponent will likely be a much more common use case.