Remove the use of mem::zeroed() from generated code
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
force-pushed
the
fix-offset-of-again
branch
from
13ba566
to
a16f446
Compare
|
@joshtriplett Do you have any chance to use this patch before merging? |
|
@JohnTitor That partially fixes the issue, but the other uses of |
JohnTitor
changed the title
offset_of macro on generated codemem::zeroed() from generated code
JohnTitor
force-pushed
the
fix-offset-of-again
branch
from
9b669fb
to
e8b215c
Compare
|
Good call, I totally overlooked them. |
|
@JohnTitor That fixed the problem, thank you! I can run the libz-sys systest suite with ctest2 from this PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31