Swap size and value args in roundtrip tests #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a disagreement on the size of the value, this can cause issues on archs that pass parameters on the stack (such as x86) leading to non-sensical errors like this: > size of struct sched_param is 28 in C and -134597808 in Rust
|
Is there any way to test it? Does it work to add a test code to |
|
@wesleywiser Friendly-ping, do you have any thoughts about the above comment? Note that the testcrate currently doesn't test items correctly (see #45), so it's fine to accept w/o a test :) |
|
Sorry! I took a look briefly the other week but couldn't quite figure out how to get a good testcase and haven't had much time to look at it again since. |
JohnTitor
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a disagreement on the size of the value, this can cause
issues on archs that pass parameters on the stack (such as x86) leading
to non-sensical errors like this:
Swapping the parameter order alleviates this: