Fix in HttpProcessor #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In WPF application the HttpProcessor was newer released and got stuck in method "StreamReadLine". This causes the application to stay alive with a zombie-process... By introducing IDisposable-interface containing an "active" flag we can shut the processor down. putting the processor in "using" it will be disposed once HttpServer is shut down.
|
Thanks, this will be in the next hotfix for sure! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo!
Schöne Grüße aus Regensburg.
Ich habe festgestellt, dass im HttpProcessor noch Prozesse aktiv bleiben können und sich so der Prozess nicht sauber beendet.
Würde mich freuen den Fix im nächsten NuGet-Package zu finden.
Gruß
J.Holzer
Hier mein Check-in-Kommentar, der den Fix erklärt:
In WPF application the HttpProcessor was newer released and got stuck in method "StreamReadLine".
This causes the application to stay alive with a zombie-process...
By introducing IDisposable-interface an an "active" flag we can shut the processor down and by
putting the processor in "using (...)" it will be disposed once HttpServer is shut down.