Rename release targets and add linux-aarch64 #559
Conversation
I'm unsure if this will work in the build workflow.
Codecov Report
@@ Coverage Diff @@
## main #559 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 14 14
Lines 5469 5469
=======================================
Hits 5350 5350
Misses 119 119 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Looks reasonable to me, but I will double check over the weekend |
There was a problem hiding this comment.
Can you also modify https://github.com/JohnnyMorganz/StyLua/blob/main/stylua-npm-bin/binary.js to point to the aarch64 version for linux?
I think we also need to update the VSCode extension (https://github.com/JohnnyMorganz/StyLua/blob/main/stylua-vscode/src/util.ts#L18), but the vscode extension also needs fixing for macos aarch64
|
I could do that, yea. Overall, it would probably be easier to template these out if the formatting of the names was consistent. Eg. everything being What do you think about that? Then I'd update this PR to overhaul the naming and update all downloaders (python and node) to use the new format. |
Yeah in hindsight this is probably what should've happened. The only thing is there are a lot of consumers and changing how the artifact was named already caused headache the first time when we removed the version |
|
Yea, is it better to just change now and get it over with though? Could probably have some period of time where the release maintains both files as well to make the transition easier. |
|
Yeah ok, let's do it. We can append "-x86_64" to the end, and keep artifacts with the old name temporarily |
.github/workflows/release.yml
Outdated
| @@ -89,6 +95,18 @@ jobs: | |||
| asset_name: ${{ matrix.artifact-name }}.zip | |||
| asset_content_type: application/zip | |||
|
|
|||
| # TODO: Remove this after deprecation notice | |||
| - name: Upload Binary to Release aliases | |||
| if: ${{ matrix.artifact-alias == "" }} | |||
There was a problem hiding this comment.
I think this condition should be negated?
| if: ${{ matrix.artifact-alias == "" }} | |
| if: ${{ matrix.artifact-alias != "" }} |
IamTheFij
changed the title
|
Ok. Fixed the condition, updated the pyproject to use the new formatting, and fixed the merge conflict by merging in master. Looks like the lint for VSCode extension failed. I'm installing npm and prettier to fix it, but I'm also making a new branch to add pre-commit hooks to the repo to make it easier to catch things like this before pushing. So far, I'm just adding the same checks that already exist in GitHub Actions. That will be a different PR. |
|
Tried a dummy run and looks like it failed with an invalid workflow file: https://github.com/JohnnyMorganz/StyLua/actions/runs/3037707302/workflow |
|
Fixed the syntax issue but looks like compiling linux aarch64 fails: https://github.com/JohnnyMorganz/StyLua/runs/8307187443?check_suite_focus=true |
|
Addressed in #572 |
I'm unsure if this will work in the build workflow.