Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aarch64 linux builds #572

Merged
merged 1 commit into from Sep 12, 2022

Conversation

IamTheFij
Copy link
Contributor

Add c toolchain and instruct cargo to use the right linker for aarch64-linux

Apparently these are required for this target only. I'm not sure how to test a gh release but I think this will work. It worked on my local Ubuntu Jammy environment.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #572 (66ff90a) into main (31da991) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   97.82%   97.82%           
=======================================
  Files          14       14           
  Lines        5469     5469           
=======================================
  Hits         5350     5350           
  Misses        119      119           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Owner

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. I can only test once I merge

@JohnnyMorganz JohnnyMorganz merged commit 91d4737 into JohnnyMorganz:main Sep 12, 2022
@JohnnyMorganz
Copy link
Owner

Ah whoops, another syntax error: https://github.com/JohnnyMorganz/StyLua/actions/runs/3039595313/workflow
Note that you need to use single quotes for strings (I should've also picked this up!)

@JohnnyMorganz
Copy link
Owner

@JohnnyMorganz
Copy link
Owner

Fixed it up, and success! https://github.com/JohnnyMorganz/StyLua/actions/runs/3039649816
image

@IamTheFij
Copy link
Contributor Author

Awesome! Thanks for the help getting this shipped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants