Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed malformed formatting of punctuated expressions list with comments #640

Merged
merged 11 commits into from
Jan 12, 2023

Conversation

JohnnyMorganz
Copy link
Owner

For multi assignments and multi returns

Closes #637

@JohnnyMorganz JohnnyMorganz added this to the 0.16 milestone Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 97.61% // Head: 97.28% // Decreases project coverage by -0.32% ⚠️

Coverage data is based on head (1c79a9d) compared to base (540ecfb).
Patch coverage: 77.10% of modified lines in pull request are covered.

❗ Current head 1c79a9d differs from pull request most recent head ccc7729. Consider uploading reports for the commit ccc7729 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
- Coverage   97.61%   97.28%   -0.33%     
==========================================
  Files          14       14              
  Lines        5614     5639      +25     
==========================================
+ Hits         5480     5486       +6     
- Misses        134      153      +19     
Impacted Files Coverage Δ
src/formatters/trivia_util.rs 92.62% <51.35%> (-2.46%) ⬇️
src/formatters/block.rs 97.68% <94.11%> (-0.22%) ⬇️
src/formatters/assignment.rs 97.97% <100.00%> (ø)
src/formatters/functions.rs 98.64% <100.00%> (-0.01%) ⬇️
src/formatters/general.rs 96.85% <100.00%> (-0.01%) ⬇️
src/formatters/stmt.rs 98.76% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Repo Comparison Test

diff --git ORI/lit/deps/coro-wrapper.lua ALT/lit/deps/coro-wrapper.lua
index f943b65..478a3e4 100644
--- ORI/lit/deps/coro-wrapper.lua
+++ ALT/lit/deps/coro-wrapper.lua
@@ -50,10 +50,10 @@ local function merger(read, scan)
 				return chunk
 			end
 		end
-	end, 
+	end,
 	-- This is used to update or disable the scan function.  It's useful for
 	-- protocols that change mid-stream (like HTTP upgrades in websockets)
-function(newScan)
+	function(newScan)
 		scan = newScan
 	end
 end

@JohnnyMorganz JohnnyMorganz merged commit 8da1a5f into main Jan 12, 2023
@JohnnyMorganz JohnnyMorganz deleted the punctuated-comments branch January 12, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed formatting of double function return with comment in between
1 participant