Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "set changelist" to FileExplorer Context menu #252

Closed
Guema opened this issue May 3, 2018 · 12 comments · Fixed by #399 or #404
Closed

Add "set changelist" to FileExplorer Context menu #252

Guema opened this issue May 3, 2018 · 12 comments · Fixed by #399 or #404

Comments

@Guema
Copy link

Guema commented May 3, 2018

  • VSCode Version: 1.22.2
  • OS Version: Win 7 x64
  • Extension Version: 1.29.0
  • System Language: FR-fr
  • SVN Version: 1.9.4

Feature request

Allow to also "add to a changelist" to file explorer right click (context) menu.

explaination :

  • It is coherent because user could want to add a file that isn't opened or not changed yet
  • Right click is easy to use
  • Could be a cool plus if it allow to add multiple files to changelist too.
  • Would be coherent with "add to SVN:ignore list" which is available on both context menu and shortcut command menu

Thanks,
Guema

@JohnstonCode JohnstonCode self-assigned this Oct 17, 2018
JohnstonCode added a commit that referenced this issue Oct 30, 2018
# [1.45.0](v1.44.4...v1.45.0) (2018-10-30)

### Features

* Added set change list to explorer context ([#399](#399)) ([9a90fa7](9a90fa7)), closes [#252](#252)
@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 1.45.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Guema
Copy link
Author

Guema commented Oct 30, 2018

got this if i try to set changelist of any file or folder with file explorer
(Still works perfectly when using Source control version of the feature)
image

SVN log is irrelevant as it logs nothing when i try to do it.

Windows specific problem ?

Os : Windows 7 x64
Code : 1.28.2
SVNext : 1.45.0

@JohnstonCode JohnstonCode reopened this Oct 30, 2018
@JohnstonCode
Copy link
Owner

@Guema Will have a check tonight

@edgardmessias
Copy link
Contributor

@JohnstonCode , I see only one solution for VSCode limitation.
Create a single context menu, like "SVN Action".
The "SVN Action" is a command and receive the selected files (from doc: (fisrtFile: Uri, allFile: Uri[]))
Check avaiable commands for current selected files and show a picker to run the command.

Example: "SVN Action" >> "Set Changelist" >> "..."

@JohnstonCode
Copy link
Owner

Too many clicks for my liking. Not sure why it was working when testing but yeah it's busted now.

I can get this to work just need some time to properly think it through

@edgardmessias
Copy link
Contributor

The problem:

  • SCM: Context Menu use Resource
  • Explorer: Context Menu use Uri

Most commands use only Resource.

@edgardmessias
Copy link
Contributor

Example for compare:
addToIgnoreSCM.ts
addToIgnoreExplorer.ts

@edgardmessias
Copy link
Contributor

Last note: A non changed file not has a Resource

@JohnstonCode
Copy link
Owner

JohnstonCode commented Oct 31, 2018

Yeah, that is the problem. We need to somehow abstract that away so it doesn't matter what is passed.

We need something to better represent something Svn is aware of.

@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 1.45.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Guema
Copy link
Author

Guema commented Nov 19, 2018

Insanely awesome to use. Really practical ! thanks and good job ;)

@JohnstonCode
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants