Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on file access in network path #466

Closed
kleinandreas2002 opened this issue Jan 25, 2019 · 6 comments · Fixed by #497
Closed

Error on file access in network path #466

kleinandreas2002 opened this issue Jan 25, 2019 · 6 comments · Fixed by #497
Assignees

Comments

@kleinandreas2002
Copy link

  • VSCode Version: 1.30.2
  • OS Version: Windows_NT x64 10.0.16299
  • Extension Version: 1.47.0
  • System Language: eng
  • SVN Version: Using svn "1.9.7"

Issue

Steps to Reproduce

  1. Open folder from network path (in my case: \\fs07\aklein\vsCodeTestSvn
    command: tree
    .
    ├── .svn
    ├── example1.txt
    └── example2.txt
  2. SVN extension works properly and recognize the svn modification (see image1)
  3. Then click on the modified file 'example1.txt'
  4. Error: the svn extension stopped -> 'No source control providers registered.' (see image2)

SVN Output

[vsCodeTestSvn]$ svn info --xml \aklein\vsCodeTestSvn\example1.txt
svn: E155007: '\\fs07\aklein\aklein\vsCodeTestSvn\example1.txt' is not a working copy

It seems that the network path is not correct, because
I opened the folder with menu File->Open Folder...:

\\fs07\aklein\vsCodeTestSvn

and the svn extension looks in path:

\\fs07\aklein\aklein\vsCodeTestSvn

--> the subfolder 'aklein' is listed twice
--> This approach worked perfectly in such network paths until recently.

Screenshots

image1

image2

@Hrnkas
Copy link

Hrnkas commented Jan 30, 2019

I see similar issue, however in my case, the SVN Icon is only visible for 1 second after opening the project. After that it disappears and all I can see is the same notice: "No source control providers registered."
My Project is also on a network drive (shared roaming profile on Active Directory in Windows 10).
(\\SERVER\Redir$\Bojan\Documents\Projects\myproject)

@joshsweaney
Copy link

joshsweaney commented Feb 6, 2019

Been trying for the last 2 hours to figure out if this was something wrong with my setup, or if this was a bug. Glad to see others have the same issue. I'm on Windows 10.

@JohnstonCode there is clearly a bug in the way this extension handles working copies stored on network drives. When running "svn info --xml '\some\file\path' " in a powershell/cmd it works fine, but the same command appears to be failing ("is not a working copy") in the Output window (with Svn filter selected) of VSCode.

EDIT: Just realised that yes indeed, the issue is that the first directory of the path (the one immediately after the server name in the network path) is duplicated in the path by the SVN extension. It doesn't at first which is why when first launching VSCode the source control panel works, then the extension starts using the wrong path and VSCode no longer recognises the directory as a repository.

@JohnstonCode
Copy link
Owner

Yeah, I only use local checked out copies so never actually thought about network drives. Will need to have a look.

@Hrnkas
Copy link

Hrnkas commented Feb 21, 2019

It works fine since the latest VSCode Update (1.31.0):

Version: 1.31.0 (system setup)
Commit: 7c66f58312b48ed8ca4e387ebd9ffe9605332caa
Date: 2019-02-05T22:35:56.624Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

@Hrnkas
Copy link

Hrnkas commented Feb 22, 2019

It works fine since the latest VSCode Update (1.31.0):

Version: 1.31.0 (system setup)
Commit: 7c66f58312b48ed8ca4e387ebd9ffe9605332caa
Date: 2019-02-05T22:35:56.624Z
Electron: 3.1.2
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.17134

Ok, now it does not. Conclusion - it works sometimes. :/

@JohnstonCode JohnstonCode self-assigned this Mar 14, 2019
JohnstonCode added a commit that referenced this issue Mar 14, 2019
JohnstonCode added a commit that referenced this issue Mar 15, 2019
## [1.47.2](v1.47.1...v1.47.2) (2019-03-15)

### Bug Fixes

* Fixed windows network drive issues ([#497](#497)) ([6a6c846](6a6c846)), closes [#466](#466) [#451](#451) [#494](#494)
JohnstonCode added a commit that referenced this issue Mar 15, 2019
## [1.47.2](v1.47.1...v1.47.2) (2019-03-15)

### Bug Fixes

* Fixed windows network drive issues ([#497](#497)) ([6a6c846](6a6c846)), closes [#466](#466) [#451](#451) [#494](#494)
JohnstonCode added a commit that referenced this issue Mar 15, 2019
## [1.47.2](v1.47.1...v1.47.2) (2019-03-15)

### Bug Fixes

* Fixed windows network drive issues ([#497](#497)) ([6a6c846](6a6c846)), closes [#466](#466) [#451](#451) [#494](#494)
@JohnstonCode
Copy link
Owner

🎉 This issue has been resolved in version 1.47.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants