Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make deletion modal less intrusive #498

Merged
merged 3 commits into from
Mar 15, 2019
Merged

fix: Make deletion modal less intrusive #498

merged 3 commits into from
Mar 15, 2019

Conversation

JohnstonCode
Copy link
Owner

fixes #487

@edgardmessias
Copy link
Contributor

Maybe, use the showQuickPick with Yes and No

@JohnstonCode
Copy link
Owner Author

That's still will break dev flow iv been finding I'm deleting files/folder then typing commands which both interrupt.

@JohnstonCode JohnstonCode merged commit 1585771 into master Mar 15, 2019
@JohnstonCode JohnstonCode deleted the delete-modal branch March 15, 2019 13:03
JohnstonCode added a commit that referenced this pull request Mar 15, 2019
@JohnstonCode
chore(release): 1.47.3 [skip ci]
6cc4e1a 
## [1.47.3](v1.47.2...v1.47.3) (2019-03-15)

### Bug Fixes

* Make deletion modal less intrusive ([#498](#498)) ([1585771](1585771)), closes [#487](#487)
@JohnstonCode
Copy link
Owner Author

🎉 This PR is included in version 1.47.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workspace File deletion prompts for SVN removal breaking normal vscode UI flow
2 participants
@JohnstonCode @edgardmessias