fix: Removed use of origional fs to allow extension to work remotely #571
Conversation
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 57.69% 57.69%
=======================================
Files 110 110
Lines 4099 4099
Branches 583 583
=======================================
Hits 2365 2365
Misses 1521 1521
Partials 213 213Continue to review full report at Codecov.
|
src/extension.ts
Outdated
| @@ -166,6 +166,9 @@ export async function activate(context: ExtensionContext) { | |||
| new Disposable(() => Disposable.from(...disposables).dispose()) | |||
| ); | |||
|
|
|||
| //See https://github.com/JohnstonCode/svn-scm/issues/561 | |||
| (process as any).noAsar = true; | |||
There was a problem hiding this comment.
The trick: https://github.com/JohnstonCode/svn-scm/blob/master/src/svn.ts#L10 not work when noAsar is true
There was a problem hiding this comment.
What deps is that trick bringing in again?
There was a problem hiding this comment.
To reduce size of ".vsix", some dependencies are removed, to use the embed module in "VSCode"
|
Instead of change, add the https://www.npmjs.com/package/original-fs, work like a polyfill |
|
How does the polyfill work? I mean i know how it exports fs. But how does it not conflict with the other orgional-fs in electron? |
|
For electron, the module "original-fs" is loaded before files |
|
🎉 This PR is included in version 1.48.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #561