Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: please co-publish on Open VSX Registry #914

Closed
GitMensch opened this issue May 2, 2020 · 9 comments · Fixed by #963
Closed

FR: please co-publish on Open VSX Registry #914

GitMensch opened this issue May 2, 2020 · 9 comments · Fixed by #963
Assignees

Comments

@GitMensch
Copy link

GitMensch commented May 2, 2020

The Open VSX Registry does not include anything for subversion yet. It would be helpful to co-publish the extension there, also for easier access in Theia and VSCodium.

Details on the publishing can be found at https://github.com/eclipse/openvsx/wiki/Publishing-Extensions.

@JohnstonCode
Copy link
Owner

Not sure if this is possible as the extension uses some of the vscode dependencies like iconv-lite and jschardet.

@edgardmessias
Copy link
Contributor

As an alternative, can run the sequence:

# Add dependency
npm install --save iconv-lite jschardet

# Package again
npx vsce package -o svn-scm.vsix

# Publish
npx ovsx publish clipboard-manager.vsix -p $OVSX_TOKEN

@GitMensch
Copy link
Author

GitMensch commented Jun 8, 2020

@edgardmessias that looks nice - Would it be bad if the dependencies are always bundled (also on the market place)?

@edgardmessias
Copy link
Contributor

Yes, because it realy big depencencies

@edgardmessias
Copy link
Contributor

@GitMensch
Current vsix size: 772KB, with dependencies: 1446:KB

@GitMensch
Copy link
Author

OK, then maybe publish two extensions "svn-scm.vsix" and "svn-scm-bundled.vsix" (with the later either being bundled or having a dependency on a "meta" extension that includes the two dependencies)?

Note: The dependency is only an issue for theia, vscode based editors like VSCodium - which comes with the Open VSX Registry as its default "market" - would be fine with the "normal" extension, it just isn't published yet. So maybe a note that it only works on vscode based editors in the README and then publishing it as-is?

edgardmessias added a commit to edgardmessias/svn-scm that referenced this issue Jun 8, 2020
@GitMensch
Copy link
Author

Note: The dependency is only an issue for theia, vscode based editors like VSCodium - which comes with the Open VSX Registry as its default "market" - would be fine with the "normal" extension, it just isn't published yet. So maybe a note that it only works on vscode based editors in the README and then publishing it as-is?

Ping, I've recently installed vscodium and had to manually install this extension as it (and also the gutter extension) are not available in the open vsx registry yet. I still suggest to add a note about the compatibility/dependencies and publish as is for now.

@GitMensch
Copy link
Author

@JohnstonCode as I'm just doing the setup for another vscodium installation and needed to do the manual vsix extension I kindly request to co-publish the extension as-is to the open vsx registry.
Support of this extension in Theia, which may need a different vsix (if this is done I suggest to put these into another one and create a "svn theia bundle" that contains both), is a completely separate thing, the extension works as-is in vscodium, it just isn't found via the default extension provider, which uses open-vsx (because of the restrictive/unclear license of the vs-marketplace).

@JohnstonCode
Copy link
Owner

I think @edgardmessias approach will work. I need to add some keytar checks. If it is not available then don't try to use it. I also also need to update the readme with this information. Also think the generated bundle should be named svn-scm-ovsx.vsix to better differentiate it. I will get this all done this weekend

@JohnstonCode JohnstonCode self-assigned this Aug 5, 2020
edgardmessias added a commit to edgardmessias/svn-scm that referenced this issue Aug 5, 2020
@JohnstonCode JohnstonCode linked a pull request Aug 5, 2020 that will close this issue
JohnstonCode added a commit that referenced this issue Aug 9, 2020
Co-authored-by: Chris Johnston <chris@johnstoncode.com>
JohnstonCode added a commit that referenced this issue Aug 9, 2020
## [2.12.2](v2.12.1...v2.12.2) (2020-08-09)

### Bug Fixes

* Added Open VSX build ([#914](#914)) ([#963](#963)) ([d52c630](d52c630))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants