Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency: npm install iconv-lite #447

Closed
GitMensch opened this issue Jul 13, 2020 · 5 comments
Closed

Missing dependency: npm install iconv-lite #447

GitMensch opened this issue Jul 13, 2020 · 5 comments

Comments

@GitMensch
Copy link
Collaborator

It definitely worked in an older version (installed from vsix months ago).
Now vscode says after update + restart:

Missing dependency, go to "C:\Program Files\VSCodium" and run: npm install iconv-lite

... I don't have an npm binary here ...

As a test I've deinstalled the older version of JohnstonCode/svn-scm and manually installed the current one, result: isn't listed under the extensions after reload, when it is listed it seems to take the place of another extension and clicking on it shows the other extensions README...

The only thing to make it "clean" was to close vscodium, remove the extension from %USERPROFILE% manually.
Also reinstalling vscodium and reinstalling from current vsix leads to a non-working extension with the same issues as mentioned above.

Main question: Did I missed vscodium having iconv-lite dropped? If not: is the Win32-x64 setup broken? Or else?

@zukaitis
Copy link

I have the same issue. Installed the suggested npm package - the warning message disappeared, but SVN extension still didn't work. Now I've uninstalled the extension and can't find it in marketplace anymore

@spoenemann
Copy link
Contributor

isn't listed under the extensions after reload, when it is listed it seems to take the place of another extension and clicking on it shows the other extensions README...

Sounds like the same problem reported in #434. That should work now.

@GitMensch
Copy link
Collaborator Author

Now I've uninstalled the extension and can't find it in marketplace anymore

That's because its author did not upload it to the original marketplace, see (and vote+ask there) - JohnstonCode/svn-scm#914

Can't reproduce the svn extension issue... Before I close it: is the npm error expected?

@zukaitis
Copy link

Thanks, I've installed svn-scm extension from vsix, and now it seems to be working fine. Although I already had npm package installed, that might have helped

@stripedpajamas
Copy link
Member

@GitMensch is the npm error from VSCodium or from the extension? It is not expected from VSCodium.

@stripedpajamas stripedpajamas changed the title svn extension stopped working after updating to 1.47 Missing dependency: npm install iconv-lite Jul 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants