Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move to eslint (closes #691) #692

Merged
merged 2 commits into from
Oct 23, 2019
Merged

refactor: move to eslint (closes #691) #692

merged 2 commits into from
Oct 23, 2019

Conversation

SimonSiefke
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #692 into master will decrease coverage by 0.05%.
The diff coverage is 49.01%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
- Coverage   56.44%   56.38%   -0.06%     
==========================================
  Files         117      117              
  Lines        4401     4402       +1     
  Branches      649      649              
==========================================
- Hits         2484     2482       -2     
- Misses       1682     1685       +3     
  Partials      235      235
Impacted Files Coverage Δ
src/commands/command.ts 51.25% <100%> (-0.25%) ⬇️
src/extension.ts 70.96% <100%> (ø) ⬆️
src/model.ts 61.08% <100%> (ø) ⬆️
src/historyView/common.ts 33.09% <33.33%> (ø) ⬆️
src/proposed.ts 38.8% <37.03%> (-2.11%) ⬇️
src/util.ts 69.23% <64.28%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b62c90...42e35e4. Read the comment docs.

@JohnstonCode JohnstonCode self-requested a review October 23, 2019 18:11
Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks alot @SimonSiefke

LGTM!

@JohnstonCode JohnstonCode merged commit b67844d into JohnstonCode:master Oct 23, 2019
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.54.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants