Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update COLONY_CLAIM_TOKEN saga #3320

Merged
merged 2 commits into from
May 11, 2022
Merged

Update COLONY_CLAIM_TOKEN saga #3320

merged 2 commits into from
May 11, 2022

Conversation

ArmandoGraterol
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol commented Apr 19, 2022 •
edited
Loading

Updated COLONY_CLAIM_TOKEN saga so that it supports claiming multiple tokens, this update is necessary in order to fully implement the Claim button shown in the new "Incoming funds" aside (#3316)

TODO

  • Connect new Claim button with updated COLONY_CLAIM_TOKEN saga

Resolves #3318

@ArmandoGraterol ArmandoGraterol self-assigned this Apr 19, 2022
@ArmandoGraterol ArmandoGraterol changed the base branch from master to feature/new-incoming-funds-sections April 21, 2022 16:32
@ArmandoGraterol ArmandoGraterol force-pushed the feature/new-incoming-funds-sections branch 3 times, most recently from 65f901a to e5e3c10 Compare May 5, 2022 20:20
@ArmandoGraterol ArmandoGraterol force-pushed the feature/issue-3318-update-claim-token-saga branch from c69f834 to cc38d73 Compare May 9, 2022 17:46
@ArmandoGraterol ArmandoGraterol requested a review from a team May 9, 2022 17:48
@ArmandoGraterol ArmandoGraterol marked this pull request as ready for review May 9, 2022 17:48
rdig
rdig approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be good code-wise.

In theory I think there's a limit to how many claim transactions we can spawn, but I don't think this is going to be relevant in practice.

chinins
chinins approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@chinins chinins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@ArmandoGraterol ArmandoGraterol merged commit 7cc3999 into feature/new-incoming-funds-sections May 11, 2022
@ArmandoGraterol ArmandoGraterol deleted the feature/issue-3318-update-claim-token-saga branch May 11, 2022 23:22
This was referenced Nov 29, 2023
Open
Open
@Abuchtela Abuchtela mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdig rdig rdig approved these changes

@chinins chinins chinins approved these changes

Assignees

@ArmandoGraterol ArmandoGraterol

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "COLONY_CLAIM_TOKEN" saga
3 participants
@ArmandoGraterol @rdig @chinins