-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploration of PNPM #1249
Exploration of PNPM #1249
Conversation
As an addendum, after speaking to Chris, the resident Node guru:
|
I've been dealing with this issue for a while (~3 months) when we were on node@14. I went down a few rabbit holes, but the only fix which consistently worked in CI was manually editing
This behavior could conceivably be incorporated into a post-commit hook using |
8400fd7
to
285be6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me
1f1ae0f
to
fae6dfa
Compare
fcab0ac
to
564289d
Compare
ce55567
to
10356ab
Compare
04ed490
to
0e28454
Compare
Don't want this merged yet (requires JoinColony/colonyCDapp#2316), but interested in a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, the patching functionality is quite interesting
The versioning check script is broken, but not as a result of this PR so don't intend for it to hold it up. |
For whatever reason
- possibly with the move to Node 20 -we're having real issues with a single lockfile being installable on Linux and OSX. This comes down tofsevents
being only needed on OSX (and therefore optional elsewhere) and npm having an issue with that - see npm/cli#4828 for the ongoing issue related to this.I've explored what it would look like if we moved to pnpm. As well as the lockfile issue being resolved (I think), a couple of nice side benefits:
@nomiclabs/truffle-contract
rather than a postinstall call tosed
npm i -g pnpm@8
to install, and then just usepnpm
instead ofnpm
to call everything is all that should be necessary.NB based on top ofmaint/docker-file-builds
.