Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on fidelity bond messages #4

Merged
merged 1 commit into from
May 16, 2021
Merged

Add docs on fidelity bond messages #4

merged 1 commit into from
May 16, 2021

Conversation

chris-belcher
Copy link
Contributor

No description provided.

@chris-belcher
Copy link
Contributor Author

Fixed issues from review 3cea057

@AdamISZ
Copy link
Member

AdamISZ commented May 14, 2021

Those edits look fine, thanks.

Please include here:

https://github.com/JoinMarket-Org/JoinMarket-Docs/blame/3cea057dfe5a5e1684ee9ea1be900d05efc5ad9f/Joinmarket-messaging-protocol.md#L58

about the encryption status of the tbond private message. (Unless I missed something, it should be in the plaintext list, because the counterparties haven't negotiated the ECDH key yet).

@AdamISZ
Copy link
Member

AdamISZ commented May 14, 2021

Similar to that last thing, can you also add it into the second block of "Valid Conversation sequences". And in "private conversation in detail".

@chris-belcher
Copy link
Contributor Author

chris-belcher commented May 15, 2021

Done. Let me know what you think and I'll squish the commits.

@AdamISZ
Copy link
Member

AdamISZ commented May 15, 2021

Thanks. That's an ACK from me. Seems complete enough for the level intended.

@chris-belcher chris-belcher merged commit 5391e06 into master May 16, 2021
@chris-belcher chris-belcher deleted the fidelitybond branch May 16, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants