Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend .onion IRC as default, add I2P options #1049

Closed

Conversation

xanoni
Copy link
Contributor

@xanoni xanoni commented Oct 18, 2021

This is the next iteration of #1038

(Does not include Irc2P I2P-only IRC server. Does not include OFTC.)

@xanoni
Copy link
Contributor Author

xanoni commented Oct 18, 2021

tor is the recommended default.

That's what I put in the PR, right? sorry if I screwed up

Oh are you saying that JoinMarket already uses .onion as the default? If yes, then I guess I was too lazy to properly migrate my config and missed the change.

EDIT: But wait, my PR is against master, and master doesn't use .onion as the default. I'm very confused.

@xanoni
Copy link
Contributor Author

xanoni commented Oct 19, 2021

sorry for confusion! yes I agree tor is the recommended default. :)

Yes! I saw one of @chris-belcher's posts here a few days ago where he said that too ... seems the clearnet default is legacy and should go away

@nixbitcoin
Copy link
Contributor

On the Agora website they say that they are fixing the I2P destination (I2P (disabled currently, will be fixed)).

Stable i2p address should be forthcoming. Funded in IRC.

@kristapsk
Copy link
Member

Removing clearnet and defaulting to Tor will not be problem if #1061 is merged.

@xanoni Maybe it's best to split off adding Ilita as a separate PR from introducing I2P, which is more controversial, as I don't see any disagreements about adding new onion supporting IRC network. And adding with clearnet + Tor configs as with existing IRC networks. Then changing to Tor by default for all of them could go as a separate commit later.

@xanoni
Copy link
Contributor Author

xanoni commented Nov 5, 2021

@kristapsk

So you are suggesting this?

  1. PR that adds Ilita .onion (I didn't see clearnet, so I guess it would be disabled by default)
  2. PR that removes all the clearnet servers and enables Ilita by default
  3. PR that adds I2P (Agora, Ilita, Irc2P) — all optional

@kristapsk
Copy link
Member

@xanoni Yes, something like that. Let's just start with (1), which should be the less controversial one.

@xanoni xanoni force-pushed the use-onion-as-default-add-i2p branch from 9df83b9 to 5249fed Compare November 7, 2021 02:10
- Make .onion IRC servers the default choice across networks
- Add Ilita (.onion): http://ilitafrzzgxymv6umx2ux7kbz3imyeko6cnqkvy4nisjjj4qpqkrptid.onion
- Add Ilita I2P alternative (see link above)
- Add Agora I2P alternative: https://anarplex.net/agorairc/connect/
- Clean up server list overall
@xanoni xanoni force-pushed the use-onion-as-default-add-i2p branch from 5249fed to a34f16a Compare November 7, 2021 02:26
@xanoni
Copy link
Contributor Author

xanoni commented Nov 7, 2021

@kristapsk that would be here: #1065

@AdamISZ
Copy link
Member

AdamISZ commented Dec 22, 2021

@kristapsk given your last comment, should this PR be closed then ( (1) is already done, so I believe we would be waiting on (2) and (3), then, unless they're already here and I missed them)?

@kristapsk
Copy link
Member

kristapsk commented Dec 22, 2021

It looks there is no consensus in adding I2P and non-onion IRC servers, so this, #1038 and #920 could be closed. They also are less important if we both add c-lightning transport (#1000) and integrate Tor (#1061).

@xanoni
Copy link
Contributor Author

xanoni commented Mar 26, 2022

Thank you for driving this. I'm MIA and can't help here right now.

@AdamISZ
Copy link
Member

AdamISZ commented Apr 22, 2022

Closing this based on the merging of #1182 and #1061 meaning we now have Tor as the default for IRC connections (and non-IRC connections, also Tor).

If there's a plan to include I2P support perhaps it could be in a new PR? (I don't know if that's possible, but in any case, I think if there were a desire to add some kind of I2P support it could be perhaps added as a variant of the new onion-based quasi-p2p messaging with directory servers, instead of IRC servers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants