Fix sendpayment without amount argument, BIP21 only #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug introduced with 83c6bc0
|
Agreed, that's what I did to fix it too :) utACK. As I noted a couple of years ago, our sendpayment code got way too difficult to parse (I mean: there are a lot of complex conditional branchings), because we kept adding new options piecemeal. If someone wants to rationalize it, so that it's easier to follow, and therefore easier to manage, that would be great. |
|
It's bad that there is no test coverage, as that code is complex enough to accidentally break things from time to time. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1356. Bug was introduced with #1316.