Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When looking for a free TCP ports, bind only to localhost #1648

Merged

Conversation

kristapsk
Copy link
Member

@kristapsk kristapsk commented Feb 1, 2024

Not a real security issue, as this is only used in tests, but it's simple to fix and right thing to do. Found by GitHub CodeQL code scanner.

@kristapsk
Copy link
Member Author

This affects only tests and tests pass, merging.

@kristapsk kristapsk merged commit 5c79a83 into JoinMarket-Org:master Feb 1, 2024
9 checks passed
@kristapsk kristapsk deleted the get_free_tcp_ports-bind-localhost branch February 1, 2024 18:09
kristapsk added a commit that referenced this pull request Feb 13, 2024
8e6eca8 Add CodeQL code scanning (Kristaps Kaupe)

Pull request description:

  Add [GitHub CodeQL](https://docs.github.com/en/code-security/code-scanning/introduction-to-code-scanning/about-code-scanning-with-codeql) code scanning.

  #1648 was already found while testing it.

Top commit has no ACKs.

Tree-SHA512: dd7ca6b21d13f0a1022a613f6f4e0184d17f9a7cd176e7d26060fdc39344b28237f77d1c4be439b96327b528688bb91dd1813c53db769047a39cad0abcd18e31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant