Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes and version for v0.9.11 #1671

Merged
merged 1 commit into from Feb 22, 2024

Conversation

kristapsk
Copy link
Member

@kristapsk kristapsk commented Feb 19, 2024

Please review and test. Treat this as a release candidate. :)

@kristapsk kristapsk force-pushed the release-notes-0.9.11 branch 2 times, most recently from f4df53f to 5d630f5 Compare February 19, 2024 23:41
docs/release-notes/release-notes-0.9.11.md Outdated Show resolved Hide resolved
docs/release-notes/release-notes-0.9.11.md Outdated Show resolved Hide resolved
docs/release-notes/release-notes-0.9.11.md Outdated Show resolved Hide resolved
docs/release-notes/release-notes-0.9.11.md Outdated Show resolved Hide resolved
@MarnixCroes
Copy link
Contributor

lgtm, few nits

@AdamISZ
Copy link
Member

AdamISZ commented Feb 20, 2024

LGTM at dd462a6

Though it's outside the norm, it would not be unreasonable to shout out @whitslack specifically for an extremely significant contribution here (in the section on wallet performance). Whatever you think, it's not a huge deal.
A vaguely related point: the description of how wallet syncing performance has improved is good, but I'm wondering if we could add this point (because it's such a common, big, problem for users): that if they are syncing a heavily used wallet from a seedphrase on a new Core instance, they can now use a large -g gaplimit and it will take far less time than it did before. I think your description of the ability to disable caching is fine. Another thing you could mention (maybe?) is that the size of the *.jmdat files will be larger than before, and that this is normal, because it contains cached data (but still encrypted).

Co-authored-by: Marnix <93143998+MarnixCroes@users.noreply.github.com>
@kristapsk
Copy link
Member Author

Addressed review comments by @MarnixCroes and @AdamISZ.

Though it's outside the norm, it would not be unreasonable to shout out @whitslack specifically for an extremely significant contribution here (in the section on wallet performance).

Added that to "Credits" section. Also mentioned new first time contributors.

@AdamISZ
Copy link
Member

AdamISZ commented Feb 21, 2024

ACK 053e9d8

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack 053e9d8

@kristapsk kristapsk merged commit f4c2b1b into JoinMarket-Org:master Feb 22, 2024
9 of 11 checks passed
@kristapsk kristapsk deleted the release-notes-0.9.11 branch February 22, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants