Handle None enter_seed_callback() response
#1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapsk
force-pushed
the
qt-wallet-recover
branch
from
2cdfbaa
to
009f0d9
Compare
kristapsk
force-pushed
the
qt-wallet-recover
branch
from
009f0d9
to
8eb55be
Compare
roshii
reviewed
May 15, 2024
Comment on lines
+724
to
+734
| def wallet_generate_recover_bip39(method: str, | ||
| walletspath: str, | ||
| default_wallet_name: str, | ||
| display_seed_callback: Callable[[str, str], None], | ||
| enter_seed_callback: Optional[Callable[[], Tuple[Optional[str], Optional[str]]]], | ||
| enter_wallet_password_callback: Callable[[], str], | ||
| enter_wallet_file_name_callback: Callable[[], str], | ||
| enter_if_use_seed_extension: Optional[Callable[[], bool]], | ||
| enter_seed_extension_callback: Optional[Callable[[], Optional[str]]], | ||
| enter_do_support_fidelity_bonds: Callable[[], bool], | ||
| mixdepth: int = DEFAULT_MIXDEPTH) -> bool: |
There was a problem hiding this comment.
Shouldn' t we use black to consistently format code?
There was a problem hiding this comment.
What is that? Have no experience with it.
There was a problem hiding this comment.
It is a Python code formatter. See https://black.readthedocs.io/en/stable/
It can be integrated to most IDE or via a pre-commit hook
Real nice I have to say, you just don't have to bother about formatting any-longer, it does it all for you :)
There was a problem hiding this comment.
Probably something to consider, but I don't see it as a top priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1698. Also added type hints.