PySide2 version pinned to 5.14.2 #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #737. Before this commit, startup of Joinmarket-Qt does not necessarily work "out of the box" due to changes in PyQt 5.15 that create external dependencies on shared libraries, see comments on the Issue for details. While we had formerly pinned PyQt 5.14, it is in fact necessary to also pin the version of PySide2 to the same 5.14.2 to remove the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737. Before this commit, startup of
Joinmarket-Qt does not necessarily work "out
of the box" due to changes in PyQt 5.15 that
create external dependencies on shared libraries,
see comments on the Issue for details.
While we had formerly pinned PyQt 5.14, it is
in fact necessary to also pin the version of
PySide2 to the same 5.14.2 to remove the
problem.