Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1 version bump #938

Merged
merged 1 commit into from Aug 4, 2021
Merged

Conversation

kristapsk
Copy link
Member

Argument why use specific commit of secp256k1 was to have the same version as coincurve uses (https://github.com/JoinMarket-Org/joinmarket-clientserver/pull/536/files#r418937166). Since January coincurve uses f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7.

Related - fort-nix/nix-bitcoin#371.

secp256k1_lib_tar='0d9540b13ffcd7cd44cc361b8744b93d88aa76ba'
secp256k1_lib_sha="0803d2dddbf6dd702c379118f066f638bcef6b07eea959f12d31ad2f4721fbe1"
secp256k1_lib_tar='f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7'
secp256k1_lib_sha="bdcb0373cc830271733841cf507ad2bb95d61be558f5334c8ad304d127ee4da9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified:

-> ~ wget https://github.com/bitcoin-core/secp256k1/archive/f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7.tar.gz
-> ~ sha256sum f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7.tar.gz 
bdcb0373cc830271733841cf507ad2bb95d61be558f5334c8ad304d127ee4da9  f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7.tar.gz

@AdamISZ
Copy link
Member

AdamISZ commented Jul 27, 2021

Notes on potential things to pay attention; first, these are commits since f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7 :
1f233b3fa05eb29a744487e0682d925055fb0d4c Remove num/gmp support - this is part of bitcoin-core/secp256k1#831 which removes libgmp and replaces the functions with new algorithms by Peter Dettman as I understand. This might be relevant if we have gmp flags set somewhere in our stack for compilation, and need to remove them.

99f47c20ec41279075d6b3ae64c9c1a84b40a6f8 Fixes problems with ARM builds(?) identified here. (Very unlikely to matter but just in case this impacts some users of our project).

Recent big changes to the Schnorr signing API, clearly not relevant.

From 0d9540b13ffcd7cd44cc361b8744b93d88aa76ba to f2d9aeae6d5a7c7fbbba8bbb38b1849b784beef7 :

Indeed, the only changes I see to the public API are in this PR which implemented Schnorr signing.

Also worthy of note is this PR which means ECDH module is no longer considered experimental.

Given this I doubt we will see any issues. It may be that the change in removing gmp creates a performance boost, but I don't think it'll be huge so no need to rush moving forward to a version with that, I think.

@AdamISZ AdamISZ merged commit 7b846a1 into JoinMarket-Org:master Aug 4, 2021
@kristapsk kristapsk deleted the bump-secp256k1 branch August 4, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants