This repository has been archived by the owner on May 13, 2022. It is now read-only.
unmask sybil counterparties by hostmask #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I don't understand this PR, but just on a quick check of the room So it seems this is easier to fake, just use Tor? |
|
@tailsjoin The ideal solution is being fleshed out in #287, this is a short-term fix which gives sybils an incentive to get new IPs. If the easiest way for them to do so is Tor, then that's what they'll do. |
|
Understood, thanks. |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working (tested) version of #311.
I'm not certain what caused the heisenbug with
IRCMessageChannel.__privmsg(); the symptom was that it didn't strip hostmask, and didn't execute debug print statements when I tried to figure out why; yet print statements did indicate that it was running changed code. Makes me itch for modularization à la #254... any update from @ghtdak on regarding https://github.com/ghtdak/joinmarket/tree/master-refactor_v1 ?