Wallet history #484
Wallet history #484
Conversation
|
Appears to be well-isolated, can't see any impact here, so utACK. |
|
Quick record of test result as discussed on IRC: Csv data was created OK.
Same here, these checks failed.
|
|
Edited to fall back to I checked my cj withdraw transactions very carefully to find some error but everything seemed to work. Although it sounds like waxwing's problem is too many withdraws rather than incorrectly the calculated balance. |
|
grubles from IRC tried this (and got 3.2% as an effective interest rate) but didn't get any of the errors. He only deposited coins into the wallet and didnt withdraw, which suggests again it's a problem with |
|
An idea for finding the bug, for me the UTXO count from history is higher than the wallet UTXO count. So history believes there are extra UTXOs which dont actually exist. So if I compare the two UTXO sets and find their difference it should give me some clues to what went wrong. |
|
Used the above idea to find and fix the bug. Seems to work now. Please, everybody try this. |
|
Works correctly for me, feel free to merge. |
| str(r * 100) + ' %') | ||
| print('(as if yield generator was a bank account)') | ||
| except ImportError: | ||
| print('numpy/scipy not installed to unable to calculate effective ' + |
There was a problem hiding this comment.
spelling mistake here
|
note to self: must add history to the --help documentation |
- randomized default behavior! - increases complexity of input-output correlation! - estimated taker-side "fee event": 1.5x - 2x
chris-belcher
force-pushed
the
wallet-history
branch
from
2cc60d5
to
c70214d
Compare
|
Done everything, ready to merge except for two extra commits that have appeared in this PR. Somehow their hash must've changed because of me doing git rebase I have half a mind to merge anyway. |
Implementation of #200
You need to be configured to use Bitcoin Core (-txindex=1 not required), run it with:
python wallet-tool.py wallet.json historyPrints a summary for every transaction. If you have numpy/scipy installed it also calculates the effective interest rate you achieved as if yield-generators were a savings account. For my own yield generator wallet the figure is 0.67% per annum
It checks if the amount of bitcoins in the wallet is the same as the resulting amount when added up as iterating through all transactions. It also checks if the number of UTXOs in the wallet match the number found by iterating through transactions. Both these checks fail for me, and I can't figure out why.
You can create a csv file for opening with spreadsheet software too:
python wallet-tool.py --csv wallet.json history >> history.csv