Skip to content

Commit

Permalink
ENG-11: Articulations initially drawn incorrectly
Browse files Browse the repository at this point in the history
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
  • Loading branch information
iveshenry18 authored and Jojo-Schmitz committed Jul 27, 2021
1 parent f244ae3 commit 5f2b002
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions mscore/musescore.cpp
Expand Up @@ -2927,21 +2927,12 @@ void MuseScore::dropEvent(QDropEvent* event)
{
const QMimeData* dta = event->mimeData();
if (dta->hasUrls()) {
int view = -1;
foreach(const QUrl& u, event->mimeData()->urls()) {
if (u.scheme() == "file") {
QString file = u.toLocalFile();
MasterScore* score = readScore(file);
if (score) {
view = appendScore(score);
addRecentScore(score);
}
openScore(file);
}
}
if (view != -1) {
setCurrentScoreView(view);
writeSessionFile(false);
}
event->acceptProposedAction();
}
}
Expand Down

0 comments on commit 5f2b002

Please sign in to comment.