New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3 Backend] ENG-11: Articulations initially drawn incorrectly #8285
[MU3 Backend] ENG-11: Articulations initially drawn incorrectly #8285
Conversation
Wouldn't it be better to just call |
I agree that this would be much cleaner (I winced as I copy-pasted code from one method to another). I was avoiding it because I'm not sure all the implications of the migration code, and I wasn't sure whether there was a great way to test for regressions, but I'll look into it! |
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches.
2b133c0
to
1e253fc
Compare
It didn't seem to introduce any regressions as far as I could tell, so I updated the commit to take that approach. Good call! |
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Specifically when dragging-and-dropping an XML file into MuseScore, the articulations didn't layout correctly. This was due to a difference between openScore (called when opening from recent or files) and dropEvent (called when dropping). This commit removes the partially-duplicated code in dropEvent and rather calls openScore to handle loading, preventing discrepancies between the two approaches. Duplicate of musescore#8285
Resolves: ENG-11: Articulation marks initially drawn in wrong position
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between
openScore
(called when opening recent or from files) anddropEvent
(called when dropping).This commit adds the style and layout-related lines to make surescore->layout
is called after loading, which fixes the issue.There appear to be further differences regarding migration, which may be worth further investigation.This commit removes the partially-duplicated code in
dropEvent
andrather calls
openScore
to handle loading, preventing discrepanciesbetween the two approaches.