Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3 Backend] ENG-11: Articulations initially drawn incorrectly #8285

Merged

Conversation

iveshenry18
Copy link
Contributor

@iveshenry18 iveshenry18 commented Jun 8, 2021

Resolves: ENG-11: Articulation marks initially drawn in wrong position

Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening recent or from files) and
dropEvent (called when dropping).

This commit adds the style and layout-related lines to make sure score->layout is called after loading, which fixes the issue.

There appear to be further differences regarding migration, which may be worth further investigation.

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@cbjeukendrup
Copy link
Contributor

Wouldn't it be better to just call openScore from dropEvent? That would avoid code duplication and discrepancies between the different ways to open a score.

@iveshenry18
Copy link
Contributor Author

iveshenry18 commented Jun 9, 2021

Wouldn't it be better to just call openScore from dropEvent?

I agree that this would be much cleaner (I winced as I copy-pasted code from one method to another). I was avoiding it because I'm not sure all the implications of the migration code, and I wasn't sure whether there was a great way to test for regressions, but I'll look into it!

Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.
@iveshenry18
Copy link
Contributor Author

It didn't seem to introduce any regressions as far as I could tell, so I updated the commit to take that approach. Good call!

@vpereverzev vpereverzev merged commit c32913c into musescore:3.6.2_backend Jun 15, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 6, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
Specifically when dragging-and-dropping an XML file into MuseScore, the
articulations didn't layout correctly. This was due to a difference
between openScore (called when opening from recent or files) and
dropEvent (called when dropping).

This commit removes the partially-duplicated code in dropEvent and
rather calls openScore to handle loading, preventing discrepancies
between the two approaches.

Duplicate of musescore#8285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants