Fix GH#13243: Respect system fill threshold if measure is followed by vertical frame #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does work for frames at the end, but has very strange and unwanted effects to other system breaks |
Jojo-Schmitz
force-pushed
the
3.x-system-fill-threshold
branch
from
17a7964
to
f8f5f51
Compare
|
@XiaoMigros if you find the time please check my 3.x port, esp. its strange effects on system breaks not at the end of a score (or section?) |
|
It seems an older version of the PR has been implemented on your branch currently, perhaps implementing the amended commit could help? |
|
Ah, I see, thanks. |
Jojo-Schmitz
force-pushed
the
3.x-system-fill-threshold
branch
from
f8f5f51
to
011e232
Compare
|
That's not it though. My guess is the stuff after that if (shouldJustify && !MScore::noHorizontalStretch) { // debug featureis the culprit |
|
Is |
|
It is, triggered by the -L commandline option |
Jojo-Schmitz
force-pushed
the
3.x-system-fill-threshold
branch
from
011e232
to
4428042
Compare
…y vertical frame Backport of musescore#21455
Jojo-Schmitz
force-pushed
the
3.x-system-fill-threshold
branch
from
4428042
to
299f372
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
3 times, most recently
from
9164f41
to
abc8ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of musescore#21455
Resolves: musescore#13243