Skip to content
This repository has been archived by the owner on Dec 23, 2017. It is now read-only.

Commit

Permalink
update notes
Browse files Browse the repository at this point in the history
  • Loading branch information
JonJagger committed Nov 5, 2015
1 parent b4bc8fd commit 31c52b4
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 28 deletions.
2 changes: 1 addition & 1 deletion admin_scripts/rsync-daemon-on-server/setup_rsync.sh
Expand Up @@ -2,7 +2,7 @@

# as root

cd /var/www/cyber-dojo/admin_scripts/rsync
cd /var/www/cyber-dojo/admin_scripts/rsync_daemon_on_server
cp etc_rsyncd.conf /etc/rsyncd.conf
cp etc_rsyncd.secrets /etc/rsyncd.secrets
chmod 600 /etc/rsyncd.secrets
Expand Down
1 change: 1 addition & 0 deletions lib/docker_machine_runner.sh
Expand Up @@ -25,6 +25,7 @@ rsync \
# 2. run avatar's test in node's container

eval "$(docker-machine env ${node_name})"

docker run \
--rm \
--user=www-data \
Expand Down
47 changes: 20 additions & 27 deletions notes/todo-refactor.txt
@@ -1,5 +1,22 @@


stderr2stdout
Only used in
lib/HostGit.rb
lib/Bash.rb
Aim to pass bash object to HostGit?
Have it explicitly in Bash and drop Stderr2Stdout.rb file
--------------------------------------
Split off Language?+Test? page as step 1 or 2-steps setup.
(Step2 = Exercise?)
Show test file as selections are made (like exercise? -> instructions)
Show messages
o) code + test files are *unrelated* to the chosen exercise
o) ...
o) do not copy-paste code into the editor (eg from a blog article).
This is an easy way to invisible characters into your code!
--------------------------------------
dashboard-page s/progress/progress?/
--------------------------------------
There is something odd happening in
test/lib/test_docker_runner.rb
Expand All @@ -19,7 +36,7 @@ Makes it easy to do upgrades.
Split create page into two.
1. Step 1/2
Language? Tests?
Use the extra space to show the test file.
Use the extra space to show the test file (later)
First entry in manifest.json visible_filenames:
is always the test file.
Use the extra space to say
Expand All @@ -31,6 +48,7 @@ Split create page into two.
puts("All tests passed")
as this is often how cyber-dojo knows if the test passed.
o) tests have to complete in 15 seconds.
o) don't copy/paste because...
Don't make this a one-click obviously.
Keeping language and tests together also makes this
a smaller refactoring from the current code.
Expand All @@ -43,34 +61,9 @@ Split create page into two.
CREATE and CANCEL

--------------------------------------
Great new avatars 38
6 bat, bee, beetle, butterfly, crab, dolphin,
5 eagle, flamingo, fox, heron, hummingbird,
4 hyena, jellyfish, kingfisher, leopard,
6 lobster, mouse, ostrich, owl, parrot, peacock,
6 penguin, puffin, rabbit, ray, rhino, seal,
6 shark, spider, squid, squirrel, starfish, swan,
5 tiger, toucan, tuna, turtle, vulture,

Plus 10 more
antelope, bear, gopher, kangaroo, lizard,
porcupine, salmon, skunk, walrus, whale,

8x8=64
7x7=49 <---
6x6=36
5x5=25
4x4=16

6x6=36=16+20
10 bee,beetle,butterfly,crab,dolphin,flamingo,hummingbird,jellyfish,leopard,lobster
10 mouse,parrot,peacock,penguin,puffin,ray,seal,starfish,tiger,toucan

49-16=33 38-[bat,rabbit,rhino,squirrel,vulture]
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Cut from http://blog.cyber-dojo.org/2014/09/adding-new-language-and-unit-test-to-cyber-dojo.html
./check_one_language.rb has not been refactored yet...

<br>
<br>
<h2>check your output parse function</h2>
Expand Down

0 comments on commit 31c52b4

Please sign in to comment.