add shld semantics #430
add shld semantics #430
Conversation
| @@ -14,6 +14,8 @@ | |||
| #include <python2.7/Python.h> | |||
| #include <python2.7/longintrepr.h> | |||
| #elif _WIN32 | |||
| #include <cmath> | |||
| #define _hypot hypot | |||
There was a problem hiding this comment.
Why this include and define?
There was a problem hiding this comment.
mingw is giving errors in python.h if I leave these out. I figured out that I need both of these lines to avoid the error (otherwise it complains about either missing hypot or _hypot).
There was a problem hiding this comment.
Ok. Can you open a new issue for this mingw error and do a PR with theae both lines?
| @@ -0,0 +1,166 @@ | |||
|
|
|||
There was a problem hiding this comment.
Thanks to provided tests but i'm using this file for my semantics tests and also the qemu-test-x86_64.
| @@ -10481,6 +10483,85 @@ namespace triton { | |||
| this->controlFlow_s(inst); | |||
| } | |||
|
|
|||
| void x86Semantics::shld_s(triton::arch::Instruction& inst) { | |||
There was a problem hiding this comment.
Thanks for this function. The semantics is good and all my tests were successfully executed =). The coding style is not like others functions but it's not a big deal I will modify the coding style later.
|
Merged with fix |
|
I also pushed |
Also includes some fixes for mingw build.