-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sleeping and collision event issues #112
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jondolf
added
C-Enhancement
New feature or request
bugfix
A-Collision
Relates to the broad phase, narrow phase, colliders, or other collision functionality
labels
Aug 8, 2023
BTW I updated my little game jam game to main after this merge and it worked very well. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Collision
Relates to the broad phase, narrow phase, colliders, or other collision functionality
C-Bug
Something isn't working
C-Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #161.
There are currently several issues with how collision events,
CollidingEntities
and sleeping are handled.CollisionEnded
event is sent despite the bodies still being in contact from the user's perspective.CollidingEntities
not being updated.Solution
This PR aims to fix all of these issues listed above.
Collision events are handled in a much more robust way.
Contacts
hasduring_current_frame
,during_current_substep
andduring_previous_frame
properties that are used to track when to send each type of collision event or updateCollidingEntities
. This also lets us removePreviousCollisions
.Collisions against sleeping bodies are also handled better. When a collision against a sleeping body ends (through movement or despawn), the bodies are woken up. Collisions between bodies are also not discarded when they start sleeping.