Initial bevy 0.10 port #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Aceeri <conmcclusk@gmail.com>
|
Alright, ready for some feedback now. It's mostly about naming (see inline todos) |
johanhelsing
commented
Mar 12, 2023
Jondolf
reviewed
Mar 12, 2023
|
XpbdSchedule: Substep schedule: Looks like there are some ambiguities, from my knowledge they were there from before, I've tried to do a pure refactor as best I could. |
|
I think we can maybe address the ambiguities in another PR, as it doesn't seem to be strictly related to the 0.10 migration or caused by it |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the high-level xpbd algorithm structure to take advantage of bevy_ecs schedule v3 (i.e. stageless).
The algorithm is split into two schedules, one high-level for running one high-level physics step (i.e.
DELTA_TIME) step, and one lower-level for the inner substepping (integrate, solve etc.).