refactor(Queue): isValid 메서드 내부 로직 getDepositActionCount로 분리

Jong1co · Apr 27, 2024 · a9fa54d · a9fa54d
1 parent 6cf749b
commit a9fa54d
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/service/Queue.ts b/src/service/Queue.ts
@@ -19,8 +19,8 @@ export class BankAccountServiceQueueImpl implements BankAccountServiceQueue {
   private queue: Array<BankAccountQueueNode> = [];
   private isExec: boolean = false;
 
-  isValid = () => {
-    const depositActionCountMap = this.queue.reduce((accr, curr) => {
+  private getDepositActionCount = (queue: Array<BankAccountQueueNode>) => {
+    return queue.reduce((accr, curr) => {
       if (curr.action !== "deposit") return accr;
 
       if (accr[curr.id]) {
@@ -31,6 +31,10 @@ export class BankAccountServiceQueueImpl implements BankAccountServiceQueue {
 
       return accr;
     }, {} as Record<number, number>);
+  };
+
+  isValid = () => {
+    const depositActionCountMap = this.getDepositActionCount(this.queue);
 
     const isInvalidAction = Object.values(depositActionCountMap).some(
       (count) => count > 1