Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix defaults for t1-t0 #43

Merged
merged 12 commits into from
Jun 9, 2023
Merged

Fix defaults for t1-t0 #43

merged 12 commits into from
Jun 9, 2023

Conversation

JoranAngevaare
Copy link
Owner

Using the last and first value is more intuitive especially as we already apply a selection while loading

@coveralls
Copy link

coveralls commented Jun 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5222549439

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 78.694%
Files with Coverage Reduction New Missed Lines %
optim_esm_tools/analyze/cmip_handler.py 4 80.9%
Totals Coverage Status
Change from base Build 5222309361: 0.07%
Covered Lines: 506
Relevant Lines: 643
💛 - Coveralls

@JoranAngevaare JoranAngevaare merged commit 8877ed1 into master Jun 9, 2023
@JoranAngevaare JoranAngevaare deleted the fix_defaults branch June 9, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoranAngevaare @coveralls