Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CommandAPI plugin messaging system (Fix CommandAPIVelocity#updateRequirements) #467

Open
wants to merge 18 commits into
base: dev/dev
Choose a base branch
from
Open

Create CommandAPI plugin messaging system (Fix CommandAPIVelocity#updateRequirements) #467

wants to merge 18 commits into from

Commits on Aug 15, 2024

  1. Implement CommandAPI plugin networking system 

    Implement CommandAPIVelocity#updateRequirements by sending a ClientToServerUpdateRequirementsPacket to trigger CommandAPIBukkit#updateRequirements
    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9c5d491 View commit details
    Browse the repository at this point in the history

  2. Address SonarCloud code smells in CommandAPIProtocol

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    958dae2 View commit details
    Browse the repository at this point in the history

  3. Register Bukkit outgoing plugin messaging channel

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    27a0d48 View commit details
    Browse the repository at this point in the history

  4. Add CommandAPIMessengerTests in commandapi-bukkit-test-tests

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c92d65e View commit details
    Browse the repository at this point in the history

  5. Address SonarCloud issues

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e4ce236 View commit details
    Browse the repository at this point in the history

  6. Clean up formatting in CommandAPIMessengerTests

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5653e23 View commit details
    Browse the repository at this point in the history

  7. Fix inconsistent this usage in BukkitCommandAPIMessenger

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a7e7331 View commit details
    Browse the repository at this point in the history

  8. Throw ProtocolVersionTooOldException if ClientToServerUpdateRequireme… 

    …ntsPacket is attempted to be sent to target that won't do anything with it

Adapt CommandAPIProtocol to support multiple channels
- Add CommandAPIPacketHandlerProvider
- Rename `commandapi:plugin` to `commandapi:play`
- Add HANDSHAKE channel

Add SetVersionPacket
- Add (more) event listeners to BukkitCommandAPIMessenger and VelocityCommandAPIMessenger to handle sending the SetVersionPacket

Add ProtocolVersionTooOldException and ProtocolVersionTooOldPacket

Add FriendlyByteBuffer
- Use it for fancy VarInt encoding (and more in the future?)
- Avoid google/guava#937 silliness by making the method yourself!

Tests! (in the dev.jorel.commandapi.test.network package :o)
- FriendlyByteBufferTests
- NetworkTestBase handles common utility and setup
- CommandAPIMessengerTests reworked
- Packet tests in separate classes
    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    e88e806 View commit details
    Browse the repository at this point in the history

  9. Fix javadoc error in FriendlyByteBuffer 

    For some reason that stopped the entire GitHub actions build https://github.com/JorelAli/CommandAPI/actions/runs/5617486381/job/15221661407#step:4:1439
Whoops
    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    19ac449 View commit details
    Browse the repository at this point in the history

  10. Address some SonarCloud code smells in new network classes

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    825aa24 View commit details
    Browse the repository at this point in the history

  11. Remove direction of travel from packet class name to get UpdateRequir… 

    …ementsPacket

Credit #467 (comment) from @DerEchtePilz.
I couldn't figure out how to directly include the suggestion and refactor everything else.
    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6155c49 View commit details
    Browse the repository at this point in the history

  12. Reduce boilerplate by making packets records

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    72a3c15 View commit details
    Browse the repository at this point in the history

  13. Throw exception if unknown packet tries to be handled

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    444b495 View commit details
    Browse the repository at this point in the history

  14. Fix UpdateRequirementsPacketTests being skipped because MockPlayer#up… 

    …dateCommands threw UnsupportedOperationException
    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a625f58 View commit details
    Browse the repository at this point in the history

  15. Fix tests failing on 1.16 and 1.17 because those versions didn't impl… 

    …ement certain plugin messaging related methods
    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7b5b5c0 View commit details
    Browse the repository at this point in the history

  16. Create simple networking only plugin for Bukkit

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    400e17f View commit details
    Browse the repository at this point in the history

  17. Tweak some javadocs and class names in `commandapi-bukkit-networking-… 

    …plugin`
    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    2599f62 View commit details
    Browse the repository at this point in the history

  18. Update some notes in the code

    @willkroboth
    willkroboth committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    dba581b View commit details
    Browse the repository at this point in the history