Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-63462 Configuration Admin Web does not display internationalized string correctly #702

Closed
wants to merge 51 commits into from
Closed

LPS-63462 Configuration Admin Web does not display internationalized string correctly #702

wants to merge 51 commits into from

Conversation

drewbrokke
Copy link

This is an update for LPS-63462.

@JorgeFerrer, I'm curious what pattern we want to follow in the jsps. I see in the java classes we're using ResourceBundleUtil.getString to retrieve translations, but in most jsps we use LanguageUtil.get. There are a few jsps where we use ResourceBundleUtil.getString. Do we have a preference?

/cc @pei-jung @csierra

dustinryerson and others added 30 commits April 5, 2016 06:46
@dustinryerson @natecavanaugh
LPS-64627 Use calculated timeOffset for determining elapsed time beca…
b01c4ed 
…use browsers can throttle JavaScript timers
@natecavanaugh
LPS-64627 - Source formatting; Remove if statement if it is the only …
f9d132c 
…statement in an else block and change it to else if
@dustinryerson @natecavanaugh
LPS-64627 Take into account that timestamp can also return as a string
060d510
@dustinryerson @natecavanaugh
LPS-64627 SF
69446b6
@natecavanaugh
LPS-64627 - Remove unused JS variable
7247f02
@natecavanaugh
LPS-64627 - Source formatting
c22931f
@juliocamarero @brianchandotcom
LPS-64873 guest site should never be deactivated
a42095d
@brianchandotcom
LPS-64841 Validate staging permission only for DDL
937bd3a
@brianchandotcom
LPS-64810 Add name to parameterMap
7464e4a
@brianchandotcom
LPS-64810 Fix cmd
725bf6f
@samuelkong @brianchandotcom
LPS-64877 References to AutoLogin's package in portal.properties is i…
fcf9974 
…ncorrect
@samuelkong @brianchandotcom
LPS-64877 Also fix for CASAutoLogin
0b2a7d6
@pavel-savinov @brianchandotcom
LPS-64834 use appropriate property names for panel items number and d…
3f15648 
…isplay style
@slnn @brianchandotcom
LPS-64804 Increase the size of queue in Elasticsearch to avoid the fa…
ad8dc45 
…ilure of index
@shuyangzhou @brianchandotcom
LPS-64804 SF
e6fed96
@brianchandotcom
LPS-64784 Build resource paths properly
7b17b55
@brianchandotcom
LPS-64784 Replace with local service call to prevent permission checking
5fe5d61
@brianchandotcom
LPS-64784 Simplify
28ea539
@rafaprax @brianchandotcom
LPS-64787 DDL Form Templates not saving changes in Site Admin
edc73aa
@hhuijser @brianchandotcom
LPS-61420 Improve regex
8fc6f0e
@hhuijser @brianchandotcom
LPS-61420 Source formatting
4040136
@hhuijser @brianchandotcom
LPS-61420 Catch incorrect spaces at beginning of line in *.jsp(f)
c85ace6
@hhuijser @brianchandotcom
LPS-61420 SF
25c4e2d
@hhuijser @brianchandotcom
LPS-61420 Lines inside annotations can be longer than 80 char, but ke…
e4b8b51 
…ep one parameter per line in that case
@hhuijser @brianchandotcom
LPS-61420 Source formatting
cbad3ee
@hhuijser @brianchandotcom
LPS-61420 Add method processErrorMessage to interface SourceProcessor
be7abe4
@hhuijser @brianchandotcom
LPS-61420 Rename parameters
e28312e
@hhuijser @brianchandotcom
LPS-61420 Add another method calculateTabs to JavaSourceTabCalculator…
8066573 
… where we can pass lineCount and tabLevel
@hhuijser @brianchandotcom
LPS-61420 Use logic in JavaSourceTabCalculator to check correct tabbi…
d9fa5ae 
…ng in javasource in *.jsp(f)
@hhuijser @brianchandotcom
LPS-61420 Source formatting
d13ba89
brianchandotcom and others added 21 commits April 5, 2016 10:13
@drewbrokke drewbrokke mentioned this pull request Apr 5, 2016
Closed
@liferay-continuous-integration
Copy link
Collaborator

Some tests FAILED!

Build Time: 1 hour 9 minutes 6 seconds

Base Branch:

Branch Name: master
Branch GIT ID: b4abd39a77c89925c6a898e04052361af4c73364

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    55 Jobs Passed.
    2 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk7/3
    Job Results:

    30 Tests Passed.
    1 Test Failed.

    1. PoshiRunner.test[CPSitememberships#OrganizationsView] - Poshi Report - Poshi Summary - Console Output

@JorgeFerrer
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@JorgeFerrer
Copy link
Owner

Pull request submitted to brianchandotcom#38585.

:octocat: Sent from GH.

@JorgeFerrer JorgeFerrer closed this Apr 7, 2016
@drewbrokke drewbrokke deleted the LPS-63462 branch November 16, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone