Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal for the different verbosity levels of the field #37

Closed
Josef-Friedrich opened this issue Aug 8, 2023 · 5 comments
Closed

Proposal for the different verbosity levels of the field #37

Josef-Friedrich opened this issue Aug 8, 2023 · 5 comments

Comments

@Josef-Friedrich
Copy link
Owner

  • verbosity=0: 'L'
  • verbosity=1: 76 ('L')
  • verbosity=2: char: 76 ('L')
  • verbosity=3: char: 76 (0x4c, 'L')
@lemzwerg
Copy link
Contributor

lemzwerg commented Aug 9, 2023

Good idea! The only question is what to do if we have '???'...

@Josef-Friedrich
Copy link
Owner Author

  • verbosity=0: 'L' or 76
  • verbosity=1: 76 ('L')
  • verbosity=2: char: 76 ('L')
  • verbosity=3: char: 76 (0x4c, 'L')

@lemzwerg
Copy link
Contributor

lemzwerg commented Aug 9, 2023

I think that number 76 out of the blue is confusing. What about

  • verbosity=0: 'L' or char76
  • verbosity=1: 76 ('L')
  • verbosity=2: char: 76 ('L')
  • verbosity=3: char: 76 (0x4c, 'L')

@lemzwerg
Copy link
Contributor

I retract my suggestion. Your idea is the right one.

lemzwerg added a commit to lemzwerg/nodetree that referenced this issue Aug 11, 2023
@lemzwerg
nodetree.lua: Make display of char field dependent on verbosity
5344133 
This handles issue Josef-Friedrich#37.
@lemzwerg
Copy link
Contributor

Fixed with commit 5344133.

Please close this issue 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Josef-Friedrich @lemzwerg