Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ported to MS3 #19

Closed
wants to merge 1 commit into from
Closed

ported to MS3 #19

wants to merge 1 commit into from

Conversation

jeetee
Copy link
Contributor

@jeetee jeetee commented May 10, 2019

it doesn't have access to the partNames yet, so those are numbered now.

@JosephEoff
Copy link
Owner

Hmm. I don't think I want this in Master. Not that there's something wrong with what you've done, I'd just rather keep the MuseScore2 Plugin separate from the MuseScore3 Plugin.

I'll have to set up a new project or repository for this. Not tonight, though. Got a couple of other things to finish up.

@JosephEoff
Copy link
Owner

I setup a new repository after all, and pulled your port into it.
Repository:
https://github.com/JosephEoff/MuseScore_UltraStar_Exporter_MS3

@JosephEoff JosephEoff closed this May 10, 2019
@jeetee
Copy link
Contributor Author

jeetee commented May 11, 2019

Fair enough. That was fast!
For my plugins I move the current "master" to a 2.x branch and update master to 3, assuming that some fixes/additional features will apply to both. Whatever floats your boat :)

@jeetee jeetee deleted the port_to_ms3 branch May 11, 2019 10:38
@jeetee
Copy link
Contributor Author

jeetee commented May 11, 2019

Will you update https://musescore.org/en/project/ultrastar-export-plugin with additional links to the 3.x version, or do you wish me to do so?

@JosephEoff
Copy link
Owner

I'll update the links when I'm on my PC. Tomorrow afternoon, probably.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants