implement Env#select!

JosephKu · Jun 21, 2012 · 2839b68 · 2839b68
1 parent 58f237c
commit 2839b68
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/env.c b/env.c
@@ -347,6 +347,31 @@ env_select(VALUE ehash, SEL sel)
     return result;
 }
 
+static VALUE
+env_select_bang(VALUE ehash, SEL sel)
+{
+    volatile VALUE keys;
+    long i;
+    int del = 0;
+
+    RETURN_ENUMERATOR(ehash, 0, 0);
+    keys = env_keys(Qnil, 0);	/* rb_secure(4); */
+    for (i=0; i<RARRAY_LEN(keys); i++) {
+	VALUE val = rb_f_getenv(Qnil, 0, RARRAY_AT(keys, i));
+	if (!NIL_P(val)) {
+	    if (!RTEST(rb_yield_values(2, RARRAY_AT(keys, i), val))) {
+		rb_obj_untaint(RARRAY_AT(keys, i));
+		env_delete(Qnil, RARRAY_PTR(keys)[i]);
+		del++;
+	    }
+	}
+    }
+    if (del == 0) {
+	return Qnil;
+    }
+    return envtbl;
+}
+
 static VALUE
 rb_env_clear_imp(VALUE rcv, SEL sel)
 {
@@ -710,6 +735,7 @@ Init_ENV(void)
     rb_objc_define_method(klass, "reject", env_reject, 0);
     rb_objc_define_method(klass, "reject!", env_reject_bang, 0);
     rb_objc_define_method(klass, "select", env_select, 0);
+    rb_objc_define_method(klass, "select!", env_select_bang, 0);
     rb_objc_define_method(klass, "shift", env_shift, 0);
     rb_objc_define_method(klass, "invert", env_invert, 0);
     rb_objc_define_method(klass, "replace", env_replace, 1);

diff --git a/spec/frozen/tags/macruby/core/env/select_tags.txt b/spec/frozen/tags/macruby/core/env/select_tags.txt