Fix-up "mark as read" #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for subreddit emotes * Fix bug with displaying subreddit emotes * Block function while emote is being downloaded * Pre-cache subreddit emotes when pre-caching comments * Add null check to subreddit emote url when pre-caching * Assign new emote tag for emotes & fix img tag parsing * Make emote download non-blocking * Fixed some comment rendering bugs * Thread safety bugfixes * Name fix * Don't precache emotes in the post list (to avoid parsing tons of comment JSON) * Don't throw away exceptions --------- Co-authored-by: QuantumBadger <git@redreader.org>
…discoverable (QuantumBadger#1047) * Define accessibility hints to make click and long click actions more discoverable * Fixing checkstyle issue * Use nullable int rather than -1 --------- Co-authored-by: QuantumBadger <git@redreader.org>
|
Closing in favour of QuantumBadger#1049. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: