Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #20 #21

Merged
merged 1 commit into from
Jan 21, 2018
Merged

Closes #20 #21

merged 1 commit into from
Jan 21, 2018

Conversation

JoshCheek
Copy link
Owner

  • Remove deprecated settings, update renamed ones
  • Use "ruby" as the default executable, since Sublime seems to have figured out the PATH since I last looked at it. This should prevent people from having to deal with the headache of configuring it after installing it.
  • Update README
  • Remove the --shebang call since SiB is smart enough to figure that out on its own now
  • Substitute CRLF with LF, to fix Windows Implementation Leaves behind CR Chars #20. As near as I can tell, ST uses LF internally, and only converts the line ends when the file is saved. So, SiB (correctly, I believe) printed the output with CRLF (it happens on the write to stdout, but super hard to reflect on and understand why), and when ST saw the CRLF, it ignored the CR, and only treated the LF as the line end. Thus, the CR was rendered inline and when it saved the file, it converted the LF to a CRLF, causing CRCRLF in the saved file.

@JoshCheek
Closes #20
af56be0 
* Remove deprecated settings, update renamed ones
* Use "ruby" as the default executable, since Sublime seems to have figured out the PATH since I last looked at it.
  This should prevent people from having to deal with the headache of configuring it after installing it.
* Update README
* Remove the `--shebang` call since SiB is smart enough to figure that out on its own now
* Substitute CRLF with LF, to fix #20. As near as I can tell, ST uses LF internally, and only converts
  the line ends when the file is saved. So, SiB (correctly, I believe) printed the output with CRLF
  (it happens on the write to stdout, but super hard to reflect on and understand why), and when ST
  saw the CRLF, it ignored the CR, and only treated the LF as the line end. Thus, the CR was rendered inline
  and when it saved the file, it converted the LF to a CRLF, causing CRCRLF in the saved file.
@JoshCheek JoshCheek mentioned this pull request Jan 21, 2018
Closed
@JoshCheek JoshCheek merged commit 72801fa into master Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Implementation Leaves behind CR Chars
1 participant
@JoshCheek